Re: [PATCH v5 3/3] pinctrl: qcom: Add SDX75 pincontrol driver

From: Andy Shevchenko
Date: Wed May 03 2023 - 05:49:37 EST


On Wed, May 3, 2023 at 8:39 AM Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx> wrote:
>
> Add initial Qualcomm SDX75 pinctrl driver to support pin configuration
> with pinctrl framework for SDX75 SoC.
> While at it, reordering the SDX65 entry.

...

> +#define FUNCTION(n) \
> + [msm_mux_##n] = { \
> + .func = PINCTRL_PINFUNCTION(#n, \
> + n##_groups, \
> + ARRAY_SIZE(n##_groups)) \
> + }

Or even define

#define MSM_PIN_FUNCTION(fname) \
[msm_mux_##fname] = PINCTRL_PINFUNCTION(...)

in the header for all MSM related controllers.

All the same for the rest groups (if any), otherwise use redefinition
of FUNCTION inside each file.

--
With Best Regards,
Andy Shevchenko