Re: [PATCH v5 3/3] Bluetooth: btusb: mediatek: add MediaTek devcoredump support
From: kernel test robot
Date: Wed May 03 2023 - 05:43:51 EST
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master linus/master v6.3 next-20230428]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-mediatek-com/Bluetooth-btmtk-introduce-btmtk-reset-work/20230503-070640
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/ddcbc509b5024882583d5c143ec5f4520bef860a.1683065391.git.objelf%40gmail.com
patch subject: [PATCH v5 3/3] Bluetooth: btusb: mediatek: add MediaTek devcoredump support
config: x86_64-randconfig-a016-20230501 (https://download.01.org/0day-ci/archive/20230503/202305031708.UQZ6jRn6-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/635545fc4095e7e6b159177a07b0359b7eafe482
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review sean-wang-mediatek-com/Bluetooth-btmtk-introduce-btmtk-reset-work/20230503-070640
git checkout 635545fc4095e7e6b159177a07b0359b7eafe482
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/bluetooth/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202305031708.UQZ6jRn6-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/bluetooth/btmtk.c:97:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_IDLE'
case HCI_DEVCOREDUMP_IDLE:
^
drivers/bluetooth/btmtk.c:100:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_ACTIVE'; did you mean 'BTMTK_COREDUMP_ACTIVE'?
case HCI_DEVCOREDUMP_ACTIVE:
^~~~~~~~~~~~~~~~~~~~~~
BTMTK_COREDUMP_ACTIVE
drivers/bluetooth/btmtk.c:25:2: note: 'BTMTK_COREDUMP_ACTIVE' declared here
BTMTK_COREDUMP_ACTIVE,
^
drivers/bluetooth/btmtk.c:103:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_TIMEOUT'
case HCI_DEVCOREDUMP_TIMEOUT:
^
drivers/bluetooth/btmtk.c:104:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_ABORT'
case HCI_DEVCOREDUMP_ABORT:
^
drivers/bluetooth/btmtk.c:105:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_DONE'
case HCI_DEVCOREDUMP_DONE:
^
drivers/bluetooth/btmtk.c:367:9: error: implicit declaration of function 'hci_devcd_register' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
return hci_devcd_register(hdev, btmtk_coredump, btmtk_coredump_hdr,
^
drivers/bluetooth/btmtk.c:385:9: error: implicit declaration of function 'hci_devcd_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
err = hci_devcd_init(hdev, MTK_COREDUMP_SIZE);
^
drivers/bluetooth/btmtk.c:385:9: note: did you mean 'hci_sock_init'?
include/net/bluetooth/bluetooth.h:577:5: note: 'hci_sock_init' declared here
int hci_sock_init(void);
^
>> drivers/bluetooth/btmtk.c:389:32: error: no member named 'dump' in 'struct hci_dev'
schedule_delayed_work(&hdev->dump.dump_timeout,
~~~~ ^
drivers/bluetooth/btmtk.c:394:9: error: implicit declaration of function 'hci_devcd_append' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
err = hci_devcd_append(hdev, skb);
^
drivers/bluetooth/btmtk.c:394:9: note: did you mean 'hci_dev_open'?
include/net/bluetooth/hci_core.h:1500:5: note: 'hci_dev_open' declared here
int hci_dev_open(__u16 dev);
^
drivers/bluetooth/btmtk.c:401:4: error: implicit declaration of function 'hci_devcd_complete' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
hci_devcd_complete(hdev);
^
drivers/bluetooth/btmtk.c:401:4: note: did you mean 'hci_devcd_append'?
drivers/bluetooth/btmtk.c:394:9: note: 'hci_devcd_append' declared here
err = hci_devcd_append(hdev, skb);
^
10 errors generated.
vim +389 drivers/bluetooth/btmtk.c
371
372 int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb)
373 {
374 struct btmtk_data *data = hci_get_priv(hdev);
375 int err;
376
377 if (!IS_ENABLED(CONFIG_DEV_COREDUMP))
378 return 0;
379
380 switch (data->cd_info.state) {
381 case BTMTK_COREDUMP_DISABLED:
382 err = -EINVAL;
383 break;
384 case BTMTK_COREDUMP_INIT:
> 385 err = hci_devcd_init(hdev, MTK_COREDUMP_SIZE);
386 if (err < 0)
387 break;
388 /* It is supposed coredump can be done within 5 seconds */
> 389 schedule_delayed_work(&hdev->dump.dump_timeout,
390 msecs_to_jiffies(5000));
391 fallthrough;
392 case BTMTK_COREDUMP_ACTIVE:
393 default:
394 err = hci_devcd_append(hdev, skb);
395 if (err < 0)
396 break;
397
398 if (skb->len > 12 &&
399 !strncmp((char *)&skb->data[skb->len - 13],
400 MTK_COREDUMP_END, 12))
401 hci_devcd_complete(hdev);
402
403 break;
404 }
405
406 if (err < 0) {
407 data->cd_info.state = BTMTK_COREDUMP_DISABLED;
408 kfree_skb(skb);
409 }
410
411 return err;
412 }
413 EXPORT_SYMBOL_GPL(btmtk_process_coredump);
414
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests