Re: [PATCH] watchdog: Add an IPMI watchdog driver in the watchdog framework
From: kernel test robot
Date: Tue May 02 2023 - 15:30:45 EST
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on cminyard-ipmi/for-next]
[also build test WARNING on groeck-staging/hwmon-next linus/master v6.3 next-20230428]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/minyard-acm-org/watchdog-Add-an-IPMI-watchdog-driver-in-the-watchdog-framework/20230502-230545
base: https://github.com/cminyard/linux-ipmi for-next
patch link: https://lore.kernel.org/r/20230502150215.1266526-1-minyard%40acm.org
patch subject: [PATCH] watchdog: Add an IPMI watchdog driver in the watchdog framework
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230503/202305030305.ZLru06GG-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3138708f587acacac7e95f3098e7a9587866a66e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review minyard-acm-org/watchdog-Add-an-IPMI-watchdog-driver-in-the-watchdog-framework/20230502-230545
git checkout 3138708f587acacac7e95f3098e7a9587866a66e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202305030305.ZLru06GG-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/watchdog/ipmi_wdt.c:515:5: warning: no previous prototype for 'ipmi_wdt_start' [-Wmissing-prototypes]
515 | int ipmi_wdt_start(struct watchdog_device *wd)
| ^~~~~~~~~~~~~~
>> drivers/watchdog/ipmi_wdt.c:529:5: warning: no previous prototype for 'ipmi_wdt_stop' [-Wmissing-prototypes]
529 | int ipmi_wdt_stop(struct watchdog_device *wd)
| ^~~~~~~~~~~~~
>> drivers/watchdog/ipmi_wdt.c:539:5: warning: no previous prototype for 'ipmi_wdt_ping' [-Wmissing-prototypes]
539 | int ipmi_wdt_ping(struct watchdog_device *wd)
| ^~~~~~~~~~~~~
>> drivers/watchdog/ipmi_wdt.c:550:5: warning: no previous prototype for 'ipmi_wdt_set_timeout' [-Wmissing-prototypes]
550 | int ipmi_wdt_set_timeout(struct watchdog_device *wd, unsigned int to)
| ^~~~~~~~~~~~~~~~~~~~
drivers/watchdog/ipmi_wdt.c:204:17: warning: 'preop_panic_excl' defined but not used [-Wunused-variable]
204 | static atomic_t preop_panic_excl = ATOMIC_INIT(-1);
| ^~~~~~~~~~~~~~~~
vim +/ipmi_wdt_start +515 drivers/watchdog/ipmi_wdt.c
514
> 515 int ipmi_wdt_start(struct watchdog_device *wd)
516 {
517 int rv;
518
519 mutex_lock(&ipmi_watchdog_mutex);
520 ipmi_watchdog_state = action_val;
521 rv = _ipmi_set_timeout(IPMI_SET_TIMEOUT_FORCE_HB);
522 if (rv)
523 ipmi_watchdog_state = WDOG_TIMEOUT_NONE;
524 mutex_unlock(&ipmi_watchdog_mutex);
525
526 return rv;
527 }
528
> 529 int ipmi_wdt_stop(struct watchdog_device *wd)
530 {
531 mutex_lock(&ipmi_watchdog_mutex);
532 ipmi_watchdog_state = WDOG_TIMEOUT_NONE;
533 _ipmi_set_timeout(IPMI_SET_TIMEOUT_NO_HB);
534 mutex_unlock(&ipmi_watchdog_mutex);
535
536 return 0;
537 }
538
> 539 int ipmi_wdt_ping(struct watchdog_device *wd)
540 {
541 int rv;
542
543 mutex_lock(&ipmi_watchdog_mutex);
544 rv = _ipmi_heartbeat();
545 mutex_unlock(&ipmi_watchdog_mutex);
546
547 return rv;
548 }
549
> 550 int ipmi_wdt_set_timeout(struct watchdog_device *wd, unsigned int to)
551 {
552 int rv;
553
554 mutex_lock(&ipmi_watchdog_mutex);
555 timeout = to;
556 rv = _ipmi_set_timeout(IPMI_SET_TIMEOUT_HB_IF_NECESSARY);
557 mutex_unlock(&ipmi_watchdog_mutex);
558
559 return rv;
560 }
561
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests