Re: [PATCH v9 1/6] media: verisilicon: Do not set context src/dst formats in reset functions

[Shreeya Patel]

Hi Thorsten,

On 02/05/23 16:42, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 02.05.23 08:56, Benjamin Gaignard wrote:
> > Le 01/05/2023 à 09:21, Thorsten Leemhuis a écrit :
> > > On 27.04.23 00:19, Shreeya Patel wrote:
> > > > On 20/02/23 16:18, Benjamin Gaignard wrote:
> > > > > Setting context source and destination formats should only be done
> > > > > in hantro_set_fmt_out() and hantro_set_fmt_cap() after check that
> > > > > the targeted queue is not busy.
> > > > > Remove these calls from hantro_reset_encoded_fmt() and
> > > > > hantro_reset_raw_fmt() to clean the driver.
> > > > >
> > > > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
> > > > KernelCI found this patch causes a regression in the
> > > > baseline.dmesg.alert test [1] on rk3399-rock-pi-4b [2],
> > > > see the bisection report for more details [3].
> > > >
> > > > Let us know if you have any questions.
> > > >
> > > > [1]
> > > > https://github.com/kernelci/kernelci-core/blob/main/config/rootfs/debos/overlays/baseline/opt/kernelci/dmesg.sh
> > > > [2] https://linux.kernelci.org/test/case/id/6442e825f19134d74c2e865d/
> > > > [3] https://groups.io/g/kernelci-results/message/40740
> > > Thx for the report. FWIW, regzbot noticed there is a patch that refers
> > > to the culprit that might have been landed in next after your test ran
> > > for the last time (and meanwhile it was mainlined): f100ce3bbd6 ("media:
> > > verisilicon: Fix crash when probing encoder")
> > Yes that patch should fix the probing issue.
> > Marek is working on an additional one to fix pixel format negotiation
> > but that doesn't impact the boot.
> Great, thx for the reply.
>
> Shreeya, normally I believe developers in cases like this and would have
> included
>
>   #regzbot fix: f100ce3bbd6
>
> in this mail (without the space in front of the #) to mark the
> regression as resolved. Would that be okay for you and other kernel.ci
> people? Or do you want to confirm this first?

I checked the commit pointed out and also double checked with Benjamin 
internally so
we are good to mark this as fixed.


#regzbot fix: f100ce3bbd6a


Thanks,
Shreeya Patel

> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.