Re: [PATCH] reset: mpfs: select AUXILIARY_BUS

[Conor Dooley]

On Tue, May 02, 2023 at 12:20:41PM +0200, Philipp Zabel wrote:
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
> 
> Cc: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Cc: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx>
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
>  drivers/reset/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 6aa8f243b30c..086cb23debba 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -154,7 +154,8 @@ config RESET_PISTACHIO
>  
>  config RESET_POLARFIRE_SOC
>  	bool "Microchip PolarFire SoC (MPFS) Reset Driver"
> -	depends on AUXILIARY_BUS && MCHP_CLK_MPFS
> +	depends on MCHP_CLK_MPFS

I think this `depends on` makes this patch moot, as MCHP_CLK_MPFS
selects AUXILIARY_BUS. I don't really mind if it's switched to select
for consistency, or removed entirely though, so:
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

> +	select AUXILIARY_BUS
>  	default MCHP_CLK_MPFS
>  	help
>  	  This driver supports peripheral reset for the Microchip PolarFire SoC
> -- 
> 2.39.2
>

Attachment: signature.asc
Description: PGP signature