Re: [PATCH] igb: Define igb_pm_ops conditionally on CONFIG_PM

From: Simon Horman
Date: Tue May 02 2023 - 07:29:24 EST


On Fri, Apr 28, 2023 at 04:00:09PM -0400, Tom Rix wrote:
> For s390, gcc with W=1 reports
> drivers/net/ethernet/intel/igb/igb_main.c:186:32: error:
> 'igb_pm_ops' defined but not used [-Werror=unused-const-variable=]
> 186 | static const struct dev_pm_ops igb_pm_ops = {
> | ^~~~~~~~~~
>
> The only use of igb_pm_ops is conditional on CONFIG_PM.
> The definition of igb_pm_ops should also be conditional on CONFIG_PM
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>