Re: [PATCH v3 3/4] dt-bindings: firmware: Add Qualcomm QSEECOM interface

[Maximilian Luz]

On 5/2/23 10:31, Krzysztof Kozlowski wrote:
> On 08/03/2023 23:44, Maximilian Luz wrote:
> > On 3/8/23 23:16, Rob Herring wrote:
> > > On Sun, Mar 05, 2023 at 03:21:18AM +0100, Maximilian Luz wrote:
> > > > Add bindings for the Qualcomm Secure Execution Environment interface
> > > > (QSEECOM).
> > >
> > > Pretty sure I already asked, but no answer in the commit message. Why do
> > > we need this? You've already declared the platform supports SCM calls
> > > with "qcom,scm". Why can't you probe whether you have QSEECOM or not? DT
> > > is for non-discoverable h/w we are stuck with.
> >
> > Yes, you've asked this before but I can only repeat what I've written in
> > my last response to your question: I am not aware of any way to properly
> > discover the interface at runtime from software.
> >
> > If it makes you happy, I can put this in the commit message as well...
>
> Yes, please, because commit msg should answer to "why we are doing
> this", when this is not obvious. If the reviewer asks the same twice it
> means it is not obvious.

Thanks. Hopefully I can manage to tie that (reliably) to qcom,scm and we
don't need the specific compatible for v4 any more. I will try to be more
descriptive for the next set of patches though.

Regards,
Max