RE: [PATCH v4 2/2] dt-bindings: usb: snps,dwc3: Add the compatible name 'snps,dwc3-rtk-soc'

[Stanley Chang[昌育德]]

Hi Krzysztof,

> >> On 02/05/2023 07:04, Stanley Chang wrote:
> >>> Add a new compatible name 'snps,dwc3-rtk-soc' of DT for realtek dwc3
> >>> core to adjust the global register start address
> >>>
> >>> The RTK DHC SoCs were designed, the global register address offset
> >>> at
> >>
> >> What are: "RTK" and "DHC"? These are manufactured by Synopsys as you
> >> suggest in the patch?
> >
> > RTK is Realtek.
> > DHC is the department name in Realtek and the abbreviation of the Digital
> Home Center.
> > The USB controller of RTK DHC SoCs used the DWC3 IP of Synopsys.
> 
> Then entire compatible is not correct. Vendor is Realtek not Synopsys.
> DHC is not even device name. Use real device names.

So, can we use the compatible name as 'realtek,dwc3' ?
For example,
@@ -2224,10 +2230,16 @@ static const struct dev_pm_ops dwc3_dev_pm_ops = {
 #ifdef CONFIG_OF
 static const struct of_device_id of_dwc3_match[] = {
        {
-               .compatible = "snps,dwc3"
+               .compatible = "snps,dwc3",
+               .data = (void *)DWC3_GLOBALS_REGS_START,
+       },
+       {
+               .compatible = "realtek,dwc3",
+               .data = (void *)DWC3_GLOBALS_REGS_START_FOR_RTK,
        },
        {
-               .compatible = "synopsys,dwc3"
+               .compatible = "synopsys,dwc3",
+               .data = (void *)DWC3_GLOBALS_REGS_START,
        },
        { },
 };

> >
> >>> 0x8100. The default address offset is constant at
> >>> DWC3_GLOBALS_REGS_START (0xc100). Therefore, add the compatible
> >> name
> >>> of device-tree to specify the SoC custom's global register start address.
> >>>
> >>> Signed-off-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>
> >>
> >> Based on your email, rtk could mean Realtek, so the compatible is
> >> clearly wrong.
> >
> > The compatible name "snps,dwc3-rtk-soc" wants to represent the dwc3
> > driver, which requires a different offset for Realtek SoCs
> 
> No. The compatible represents hardware, not driver. Use compatible matching
> real hardware.
> 
> Best regards,
> Krzysztof
> 
> 
> ------Please consider the environment before printing this e-mail.