Re: [PATCH v7 1/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport

[Krishna Kurapati PSSNV]

On 5/2/2023 1:18 PM, Krzysztof Kozlowski wrote:
> On 01/05/2023 16:34, Krishna Kurapati wrote:
> > Add the compatible string for SC8280 Multiport USB controller from
> > Qualcomm.
> >
> > There are 4 power event irq interrupts supported by this controller
> > (one for each port of multiport). Added all the 4 as non-optional
> > interrupts for SC8280XP-MP
> >
> > Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/usb/qcom,dwc3.yaml    | 21 +++++++++++++++++++
> >   1 file changed, 21 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > index d84281926f10..2c96da1ce5b8 100644
> > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> > @@ -26,6 +26,7 @@ properties:
> >             - qcom,sc7180-dwc3
> >             - qcom,sc7280-dwc3
> >             - qcom,sc8280xp-dwc3
> > +          - qcom,sc8280xp-dwc3-mp
>
> SC8280xp comes with two USB controllers: one single-port and one multi-port?

Hi Krzysztof,

  SC8280XP comes with 3 controllers. The first two are single port 
controller and the third one is a multiport controller. In DTSI:
usb_0 / usb1: have compatible set to : "qcom,sc8280xp-dwc3"

And multiport controller has it set to "qcom,sc8280xp-dwc3-mp"


> >             - qcom,sdm660-dwc3
> >             - qcom,sdm670-dwc3
> >             - qcom,sdm845-dwc3
> > @@ -455,6 +456,26 @@ allOf:
> >               - const: dm_hs_phy_irq
> >               - const: ss_phy_irq
> >   
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - qcom,sc8280xp-dwc3-mp
>
> You miss entries for all other constraints.
Let me add the clock properties as well.

Regards,
Krishna,