Re: [PATCH v2 0/2] Fix TPM 1.2 resume

From: Vlastimil Babka
Date: Tue May 02 2023 - 03:37:49 EST


On 5/2/23 03:15, Jarkko Sakkinen wrote:
> During TPM 1.2 resume, the first PCR read operation used inside
> tpm1_do_selftest() fails. Fix the bugs preventing resume from working.

Thanks for fixing this, unfortunately I can no longer test the fix as I've
got a new laptop since when I was hitting the bug on the older one.

Vlastimil

> v2:
> * Added Jerry's reviewed-by's.
> * Rebased to 865fdb08197e ("Merge tag 'input-for-v6.4-rc0' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input").
> * Mirrored patches to linux-next.
>
> Cc: Vlastimil Babka <vbabka@xxxxxxx>
> Cc: Jason A. Donenfeld <Jason@xxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> Cc: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>
>
> Link: https://lore.kernel.org/linux-integrity/CS6UJMSTVA4L.FRQ5VL1I1EF4@suppilovahvero/T/#m236d62184229cc035605143fde10933bcde60065
> Jarkko Sakkinen (2):
> tpm_tis: Use tpm_chip_{start,stop} decoration inside tpm_tis_resume
> tpm: Prevent hwrng from activating during resume
>
> drivers/char/tpm/tpm-chip.c | 4 +++
> drivers/char/tpm/tpm-interface.c | 10 ++++++++
> drivers/char/tpm/tpm_tis_core.c | 43 ++++++++++++++------------------
> include/linux/tpm.h | 1 +
> 4 files changed, 34 insertions(+), 24 deletions(-)
>