Re: [PATCH v8 05/11] dt-bindings: arm: Add initial bindings for Nuvoton platform

From: Krzysztof Kozlowski
Date: Tue May 02 2023 - 02:47:18 EST


On 02/05/2023 08:40, Jacky Huang wrote:
>
> Dear Krzysztof,
>
>
>
> On 2023/5/2 下午 02:31, Krzysztof Kozlowski wrote:
>> On 02/05/2023 03:31, Jacky Huang wrote:
>>> Dear Krzysztof,
>>>
>>>
>>> On 2023/5/1 下午 05:50, Krzysztof Kozlowski wrote:
>>>> On 25/04/2023 12:24, Jacky Huang wrote:
>>>>> From: Jacky Huang <ychuang3@xxxxxxxxxxx>
>>>>>
>>>>> Move 'nuvoton,npcm-gcr.yaml' from 'arm/npcm' to 'soc/nuvoton'.
>>>>> Rename the '/arm/npcm' directory to 'arm/nuvoton'. Additionally, add
>>>>> bindings for ARMv8-based Nuvoton SoCs and platform boards, and include
>>>>> the initial bindings for ma35d1 series development boards.
>>>>>
>>>>> Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
>>>>> ---
>>>>> .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++
>>>>> .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +-
>>>>> .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +-
>>>>> 3 files changed, 32 insertions(+), 2 deletions(-)
>>>>> create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
>>>> I don't see any improvements here. Path in maintainers is still broken.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>> Does this line cover
>>> 'Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml'?
>>> ==>  F:    Documentation/devicetree/bindings/*/*/*ma35*
>>>
>>> I ran 'get_maintainer.pl' on this patch, and it was able to find
>>> maintainers and looked good.
>>> I also ran 'make htmldocs' and did not see any warnings or errors
>>> related to the .yaml files
>>> in this patch. However, I am still unsure where the problem lies. Can
>>> you suggest any
>>> tools I can use to check for errors? I would greatly appreciate any
>>> guidance you can provide.
>> Apply the patches 1 to 5 and then check if all paths from maintainers
>> are correct. I believe the path
>> Documentation/devicetree/bindings/arm/npcm/ is not.
>>
>> I think I told the same last time with explanation that this patch must
>> correct path.
>>
>> Best regards,
>> Krzysztof
>>
>
> Okay, I think I should combine the patch 11 (for MAINTAINER)  into patch 5.

I don't know what's there. The path which is changed (invalidated) here,
should be updated here.

Best regards,
Krzysztof