Re: [PATCH] imx8mn-var-som: dts: add SOM EEPROM

[Hugo Villeneuve]

On Fri, 28 Apr 2023 15:06:22 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:

> On 27/04/2023 21:56, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> > 
> > The 4Kbit EEPROM located on the SOM contains hardware configuration
> > options, manufacturing infos and ethernet MAC address.
> 
> Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching).
> 
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
> > index 9052b0d4b5b4..3ed396f41e46 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi
> > @@ -30,6 +30,10 @@ reg_eth_phy: regulator-eth-phy {
> >  		gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>;
> >  		enable-active-high;
> >  	};
> > +
> > +	aliases {
> 
> Keep nodes ordered.
> 
> > +		eeprom_som = &eeprom_som;
> 
> That's no valid alias. Which upstream kernel driver makes use of this?

Is "eeprom-som" ok?

No driver uses it for now..

Hugo.

> 
> > +	};
> >  };
> >  
> 
> Best regards,
> Krzysztof
> 
> 


-- 
Hugo Villeneuve