Re: [PATCH] iio: adc: palmas: Remove the unneeded include <linux/i2c.h>

From: Jonathan Cameron
Date: Sun Apr 30 2023 - 12:48:47 EST


On Mon, 24 Apr 2023 09:11:51 +0200
Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> This driver does not use i2c, so there is no point in including
> <linux/i2c.h>
>
> Remove it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Hard to argue with that logic :)

I guess some long ago cut and paste..

Applied,

Thanks,

Jonathan

> ---
> drivers/iio/adc/palmas_gpadc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
> index c1c439215aeb..42c519504529 100644
> --- a/drivers/iio/adc/palmas_gpadc.c
> +++ b/drivers/iio/adc/palmas_gpadc.c
> @@ -14,7 +14,6 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/delay.h>
> -#include <linux/i2c.h>
> #include <linux/pm.h>
> #include <linux/mfd/palmas.h>
> #include <linux/completion.h>