Re: [PATCH v2] RISC-V: fix sifive and thead section mismatches in errata

[Evan Green]

On Sat, Apr 29, 2023 at 8:52 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> When CONFIG_MODULES is set, __init_or_module becomes <empty>, but when
> CONFIG_MODULES is not set, __init_or_module becomes __init.
> In the latter case, it causes section mismatch warnings:
>
> WARNING: modpost: vmlinux.o: section mismatch in reference: riscv_fill_cpu_mfr_info (section: .text) -> sifive_errata_patch_func (section: .init.text)
> WARNING: modpost: vmlinux.o: section mismatch in reference: riscv_fill_cpu_mfr_info (section: .text) -> thead_errata_patch_func (section: .init.text)
>
> Fixes: bb3f89487fd9 ("RISC-V: hwprobe: Remove __init on probe_vendor_features()")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> Cc: Conor Dooley <conor@xxxxxxxxxx>
> Cc: Evan Green <evan@xxxxxxxxxxxx>
> ---

Thanks, Randy. I'm confused at how I didn't see that when I made the
original fix. I feel like repro of these section mismatch errors
depend on some other factor I'm not understanding. In any case:

Reviewed-by: Evan Green  <evan@xxxxxxxxxxxx>