Re: [PATCH v2] block: Skip destroyed blkg when restart in blkg_destroy_all()

From: Tao Su
Date: Sat Apr 29 2023 - 03:12:00 EST


On Fri, Apr 28, 2023 at 11:24:20AM -0600, Jens Axboe wrote:
>
> On Fri, 28 Apr 2023 12:51:49 +0800, Tao Su wrote:
> > Kernel hang in blkg_destroy_all() when total blkg greater than
> > BLKG_DESTROY_BATCH_SIZE, because of not removing destroyed blkg in
> > blkg_list. So the size of blkg_list is same after destroying a
> > batch of blkg, and the infinite 'restart' occurs.
> >
> > Since blkg should stay on the queue list until blkg_free_workfn(),
> > skip destroyed blkg when restart a new round, which will solve this
> > kernel hang issue and satisfy the previous will to restart.
> >
> > [...]
>
> Applied, thanks!

Axboe, thanks!

Tao

>
> [1/1] block: Skip destroyed blkg when restart in blkg_destroy_all()
> commit: 8176080d59e6d4ff9fc97ae534063073b4f7a715
>
> Best regards,
> --
> Jens Axboe
>
>
>