Re: [PATCH] usb: dwc3: gadget: Fix controller timeout at dwc3_gadget_suspend()

From: Thinh Nguyen
Date: Fri Apr 28 2023 - 14:41:31 EST


On Fri, Apr 28, 2023, Roger Quadros wrote:
> If gadget driver is loaded and we are connected to a USB host,
> all transfers must be stopped before stopping the controller else
> we will not get a clean stop i.e. dwc3_gadget_run_stop() will take
> several seconds to complete and will return -ETIMEDOUT. Fix this.
>
> No need to stop the controller at dwc3_gadget_suspend() if
> dwc->softconnect is 0 as controller is already stopped.
>
> Handle error cases properly in dwc3_gadget_suspend().

We also fix the dwc3_gadget_resume() in this change. Either create a
separate change or note it in the $subject and commit message.

>
> Suggested-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
> Signed-off-by: Roger Quadros <rogerq@xxxxxxxxxx>

Perhaps this needs a fixes tag? (Even though it can't be backported
cleanly without some modifications)

Also, please rebase your change to Greg's usb-next.

Thanks!
Thinh