Re: [PATCH v3 8/8] dt-bindings: Add rt5033 mfd, regulator and charger

[Jakob Hauser]

Hi Henrik,

On 28.04.23 16:39, Henrik Grimler wrote:
> On Fri, Apr 28, 2023 at 01:30:11AM +0200, Jakob Hauser wrote:
...
> > +  regulators:
> > +    description:
> > +      The regulators of RT5033 have to be instantiated under a sub-node named
> > +      "regulators". For SAFE_LDO voltage there is only one value of 4.9 V. LDO
>
> Is only 4.9 V valid for SAFE_LDO? If I am reading driver found in
> vendor kernel for SM-A500F it seems to to allow values between 3.3 and
> 4.95 V [1]. Same range is also written in the devicetree for the
> device [2].
>
> [1] https://github.com/msm8916-mainline/linux-downstream/blob/SM-A500F/drivers/regulator/rt5033_regulator.c#L109-L114
> [2] https://github.com/msm8916-mainline/linux-downstream/blob/SM-A500F/arch/arm/boot/dts/samsung/msm8916/msm8916-sec-a5u-eur-r01.dtsi#L148-L149

You're right, the RT5033 regulator SAFE_LDO is capable of more than one 
voltage.

In the mainline rt5033-regulator driver, however, for SAFE_LDO only the 
one voltage at 4.9 V is implemented so far.
https://github.com/torvalds/linux/blob/v6.3/include/linux/mfd/rt5033-private.h#L211-L212
https://github.com/torvalds/linux/blob/v6.3/drivers/regulator/rt5033-regulator.c#L83

For the charger driver this seems sufficient.

Kind regards,
Jakob