Re: [PATCH 29/43] rtc: m48t86: add DT support for m48t86

From: Nikita Shubin
Date: Fri Apr 28 2023 - 07:31:10 EST


On Wed, 2023-04-26 at 16:36 +0300, andy.shevchenko@xxxxxxxxx wrote:
> Mon, Apr 24, 2023 at 03:34:45PM +0300, Nikita Shubin kirjoitti:
> > - get regs from device tree
>
> ...
>
> > +#include <linux/of.h>
>
> mod_devicetable.h and drop ugly ifdeffery along with of_match_ptr().
>
> ...
>
> > +static const struct of_device_id m48t86_rtc_of_ids[] = {
> > +       { .compatible = "dallas,rtc-m48t86" },
> > +       { /* end of table */ },
>
> No comma for the terminator entry
>
> > +};
>

Thanks you for all your comments and effort!

All will be fixed conforming your comments.