Re: [PATCH v3] vringh: IOMEM support

[Shunsuke Mie]

Hi Simon-san,

2023年4月27日(木) 4:21 Simon Horman <simon.horman@xxxxxxxxxxxx>:
>
> On Tue, Apr 25, 2023 at 07:22:50PM +0900, Shunsuke Mie wrote:
> > Introduce a new memory accessor for vringh. It is able to use vringh to
> > virtio rings located on io-memory region.
> >
> > Signed-off-by: Shunsuke Mie <mie@xxxxxxxxxx>
>
> ...
>
> Hi Mie-san,
>
> thanks for your patch.
> One small nit from me below.
>
> > diff --git a/include/linux/vringh.h b/include/linux/vringh.h
> > index c3a8117dabe8..c03d045f7f3f 100644
> > --- a/include/linux/vringh.h
> > +++ b/include/linux/vringh.h
> > @@ -330,4 +330,37 @@ int vringh_need_notify_iotlb(struct vringh *vrh);
> >
> >  #endif /* CONFIG_VHOST_IOTLB */
> >
> > +#if IS_REACHABLE(CONFIG_VHOST_RING_IOMEM)
> > +
> > +int vringh_init_iomem(struct vringh *vrh, u64 features,
> > +                   unsigned int num, bool weak_barriers,
> > +                   struct vring_desc *desc,
> > +                   struct vring_avail *avail,
> > +                   struct vring_used *used);
> > +
> > +
>
> nit: one blank line is enough.
It should not have included this patch. Thanks.
> > +int vringh_getdesc_iomem(struct vringh *vrh,
> > +                      struct vringh_kiov *riov,
> > +                      struct vringh_kiov *wiov,
> > +                      u16 *head,
> > +                      gfp_t gfp);
>
> ...