Re: [PATCH v2 2/3] virt: tdx-guest: Add Quote generation support

From: Dionna Amalie Glaze
Date: Thu Apr 27 2023 - 21:29:25 EST


>
> How about the following?
>
> Although this method reserves a fixed chunk of memory for GetQuote
> requests, such one-time allocation is preferable to the alternative
> choice of repeatedly allocating/freeing the shared buffer in the
> TDX_CMD_GET_QUOTE IOCTL handler, which will damage the direct map (because
> the sharing/unsharing process modifies the direct map). This allocation
> model is similar to that used by the AMD SEV guest driver.
>
>

Yes, this is clear, thank you.


--
-Dionna Glaze, PhD (she/her)