Re: [PATCH] imx8mn-var-som: dts: fix PHY detection bug by adding deassert delay

[Hugo Villeneuve]

On Thu, 27 Apr 2023 22:56:40 +0200
Andrew Lunn <andrew@xxxxxxx> wrote:

> On Thu, Apr 27, 2023 at 04:22:51PM -0400, Hugo Villeneuve wrote:
> > On Thu, 27 Apr 2023 17:07:59 -0300
> > Fabio Estevam <festevam@xxxxxxxxx> wrote:
> > 
> > > On Thu, Apr 27, 2023 at 5:06 PM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote:
> > > 
> > > > Hi Fabio,
> > > > it uses a ADIN1300 PHY.
> > > >
> > > > The datasheet indicate that the "Management interface active (t4)" state is reached at most 5ms after the reset signal is deasserted.
> > > 
> > > Please add this information to the commit log and please add a Fixes: tag.
> > > 
> > > Thanks
> > 
> > Hi,
> > I am trying to properly add a "Fixes: " tag, but the description for this tag indicates that it is to report that "the patch fixes an issue in a previous commit".
> > 
> > In this case, I cannot identify a commit that introduced that bug, apart from the initial commit of the DTS file which didn't have the reset property present?
> 
> Is the PHY on the SOM or the carrier?

It is on the SOM.

> 
> If the PHY is on the carrier, then the delay is a carrier property,
> and should be in the carrier .dts file. So use the commit for when the
> carrier DTS file was added.
> 
> If the PHY is on the SOM, then use the commit for when the SOM DTSI
> was added.

Ok, will use that.

Hugo.

-- 
Hugo Villeneuve <hugo@xxxxxxxxxxx>