Re: [PATCH v1 11/40] perf test: Test more with config_cache

[Liang, Kan]

On 2023-04-26 3:00 a.m., Ian Rogers wrote:
> test__checkevent_config_cache checks the parsing of
> "L1-dcache-misses/name=cachepmu/". Don't just check that the name is
> set correctly, also validate the rest of the perf_event_attr for
> L1-dcache-misses.
> 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

Run the test on Cascade Lake and Alder Lake. It looks good.

Tested-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

Thanks,
Kan

> ---
>  tools/perf/tests/parse-events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
> index fa016afbc250..177464793aa8 100644
> --- a/tools/perf/tests/parse-events.c
> +++ b/tools/perf/tests/parse-events.c
> @@ -1394,7 +1394,7 @@ static int test__checkevent_config_cache(struct evlist *evlist)
>  	struct evsel *evsel = evlist__first(evlist);
>  
>  	TEST_ASSERT_VAL("wrong name setting", evsel__name_is(evsel, "cachepmu"));
> -	return TEST_OK;
> +	return test__checkevent_genhw(evlist);
>  }
>  
>  static bool test__pmu_cpu_valid(void)