Re: [RFC RESEND 3/3] leds: Add support for UP board CPLD onboard LEDS

From: Lee Jones
Date: Thu Apr 27 2023 - 13:15:55 EST


On Tue, 25 Apr 2023, larry.lai wrote:

> The UP boards come with a few FPGA-controlled onboard LEDs:
> * UP Board: yellow, green, red
> * UP Squared: blue, yellow, green, red
>
> This patch depends on patch "mfd: Add support for UP board CPLD/FPGA".
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Reviewed-by: Lee Jones <lee@xxxxxxxxxx>

Definitely not. Please try again after reading:

Documentation/process/submitting-patches.rst

> Signed-off-by: larry.lai <larry.lai@xxxxxxxxxxxxxxx>
> ---
> RFC 2022/11/23 --> RFC 2023/04/25: Refer 2022/12/08 Lee Jones review,
> cleaned up coding style.
> PATCH V3 -> RFC 2022/11/23: Update the changes Copyright.
> PATCH V1 -> V3: There is no change.
> PATCH --> PATCH V1: Refer 2022/10/03 Andy Shevchenko review, cleaned up
> coding style.
> ---
> ---
> drivers/leds/Kconfig | 10 +++++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-upboard.c | 79 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 90 insertions(+)
> create mode 100644 drivers/leds/leds-upboard.c

--
Lee Jones [李琼斯]