Re: [PATCH v8 2/2] leds: lp55xx: configure internal charge pump

From: Lee Jones
Date: Thu Apr 27 2023 - 11:22:21 EST


On Fri, 21 Apr 2023, Maarten Zanders wrote:

> The LP55xx range of devices have an internal charge pump which
> can (automatically) increase the output voltage towards the
> LED's, boosting the output voltage to 4.5V.
>
> Implement this option from the devicetree. When the setting
> is not present it will operate in automatic mode as before.
>
> Tested on LP55231. Datasheet analysis shows that LP5521, LP5523
> and LP8501 are identical in topology and are modified in the
> same way.
>
> Signed-off-by: Maarten Zanders <maarten.zanders@xxxxxxx>
> ---
>
> Notes:
> v1: implement as bool to disable charge pump
> v2: rewrite to use string configuration, supporting all modes
> v3: simplification by replacing string from DTS by constant
> v4: added notes
> v5: property type to u32
> v6: cleanup parsing of DT paramter
> v7: formatting
>
> drivers/leds/leds-lp5521.c | 11 +++++------
> drivers/leds/leds-lp5523.c | 14 +++++++++-----
> drivers/leds/leds-lp55xx-common.c | 9 +++++++++
> drivers/leds/leds-lp8501.c | 8 +++++---
> include/linux/platform_data/leds-lp55xx.h | 3 +++
> 5 files changed, 31 insertions(+), 14 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]