Re: watchdog: pcwd driver updates (was: No subject)

[Guenter Roeck]

On 4/27/23 07:19, Oliver Neukum wrote:
> On 27.04.23 16:12, Guenter Roeck wrote:
> > Oliver,
> >
> > On 4/27/23 06:33, Oliver Neukum wrote:
> > > This fixes some long standing deficiencies in error handling,
> > > several race conditions and disconnect handling.
> > > Finally a cleanup as we now can get the device easily
> > > from the interface.
> >
> > This series is a no-go. If you want to improve the driver, please
> > convert it to use the watchdog subsystem API.
> >
> > Please note that the subject of your patches should start with
> > "watchdog: pcwd:"
>
> Hi,
>
> this would be problematic, because I do not have the hardware
> and given its age I won't. I certainly will break the driver
> if I do this extensive a change without testing it.
>
> However, as is the driver has obvious issues, which I can fix.
> We can either do the sensible fixes or let it quietly rot.

Several of those issues would be solved by using the watchdog subsystem.

I am not going to review patches for watchdog drivers not using
the watchdog subsystem. I would suggest to refrain from making changes
to such drivers, even more so if you don't have the hardware to test
those changes.

Thanks,
Guenter