Re: [PATCH] drm/meson: set variables meson_hdmi_* storage-class-specifier to static

From: neil . armstrong
Date: Thu Apr 27 2023 - 08:52:49 EST


On 23/04/2023 23:36, Martin Blumenstingl wrote:
On Sun, Apr 23, 2023 at 4:53 PM Tom Rix <trix@xxxxxxxxxx> wrote:

smatch has several simailar warnings to
s/simailar/similar/

drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol
'meson_hdmi_enci_mode_480i' was not declared. Should it be static?

These variables are only used in their defining file so should be static

Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
With above typo fixed (or with a comment from the maintainers that
they can fix it while applying):
Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

Thanks, fixed while applying.

Neil