Re: [PATCH] mfd: wm831x: Use maple tree register cache

From: Charles Keepax
Date: Thu Apr 27 2023 - 05:47:19 EST


On Tue, Apr 25, 2023 at 07:03:33PM +0100, Mark Brown wrote:
> regmap has introduced a maple tree based register cache which makes use of
> this more advanced data structure which has been added to the kernel
> recently. Maple trees are much flatter than rbtrees, meaning that they do
> not grow to such depths when the register map is sparse which makes access
> a bit more efficient. The maple tree cache type is still a bit of a work
> in progress but should be effective for some devices already.
>
> The wm831x devices have a pretty sparse register map and being always on
> devices never do cache syncs so don't hit the major current disadvantage
> so they should be good candiates for using the maple tree cache. Update
> to do so, there should be little if any visible difference at runtime.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles