Re: [PATCH v4 3/3] Bluetooth: btusb: mediatek: add MediaTek devcoredump support
From: kernel test robot
Date: Wed Apr 26 2023 - 23:20:43 EST
Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master linus/master v6.3 next-20230426]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-mediatek-com/Bluetooth-btmtk-introduce-btmtk-reset-work/20230427-071054
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
patch link: https://lore.kernel.org/r/01d3fe06d3a1e333b193e7d9fbc9cbfb4ee5d02b.1682549719.git.objelf%40gmail.com
patch subject: [PATCH v4 3/3] Bluetooth: btusb: mediatek: add MediaTek devcoredump support
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20230427/202304271131.HetsXcxM-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/d253c927e94cb7e88bfcd0182449d29e477ca011
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review sean-wang-mediatek-com/Bluetooth-btmtk-introduce-btmtk-reset-work/20230427-071054
git checkout d253c927e94cb7e88bfcd0182449d29e477ca011
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/bluetooth/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304271131.HetsXcxM-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/bluetooth/btmtk.c:104:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_IDLE'
case HCI_DEVCOREDUMP_IDLE:
^
>> drivers/bluetooth/btmtk.c:107:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_ACTIVE'; did you mean 'BTMTK_COREDUMP_ACTIVE'?
case HCI_DEVCOREDUMP_ACTIVE:
^~~~~~~~~~~~~~~~~~~~~~
BTMTK_COREDUMP_ACTIVE
drivers/bluetooth/btmtk.c:28:2: note: 'BTMTK_COREDUMP_ACTIVE' declared here
BTMTK_COREDUMP_ACTIVE,
^
>> drivers/bluetooth/btmtk.c:110:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_TIMEOUT'
case HCI_DEVCOREDUMP_TIMEOUT:
^
>> drivers/bluetooth/btmtk.c:111:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_ABORT'
case HCI_DEVCOREDUMP_ABORT:
^
>> drivers/bluetooth/btmtk.c:112:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_DONE'
case HCI_DEVCOREDUMP_DONE:
^
>> drivers/bluetooth/btmtk.c:372:2: error: implicit declaration of function 'hci_devcd_register' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
hci_devcd_register(hdev, btmtk_coredump, btmtk_coredump_hdr,
^
>> drivers/bluetooth/btmtk.c:389:9: error: implicit declaration of function 'hci_devcd_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
err = hci_devcd_init(hdev, MTK_COREDUMP_SIZE);
^
drivers/bluetooth/btmtk.c:389:9: note: did you mean 'hci_sock_init'?
include/net/bluetooth/bluetooth.h:577:5: note: 'hci_sock_init' declared here
int hci_sock_init(void);
^
>> drivers/bluetooth/btmtk.c:393:32: error: no member named 'dump' in 'struct hci_dev'
schedule_delayed_work(&hdev->dump.dump_timeout,
~~~~ ^
>> drivers/bluetooth/btmtk.c:398:9: error: implicit declaration of function 'hci_devcd_append' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
err = hci_devcd_append(hdev, skb);
^
drivers/bluetooth/btmtk.c:398:9: note: did you mean 'hci_dev_open'?
include/net/bluetooth/hci_core.h:1500:5: note: 'hci_dev_open' declared here
int hci_dev_open(__u16 dev);
^
>> drivers/bluetooth/btmtk.c:405:4: error: implicit declaration of function 'hci_devcd_complete' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
hci_devcd_complete(hdev);
^
drivers/bluetooth/btmtk.c:405:4: note: did you mean 'hci_devcd_append'?
drivers/bluetooth/btmtk.c:398:9: note: 'hci_devcd_append' declared here
err = hci_devcd_append(hdev, skb);
^
10 errors generated.
vim +/HCI_DEVCOREDUMP_IDLE +104 drivers/bluetooth/btmtk.c
100
101 static void btmtk_coredump_notify(struct hci_dev *hdev, int state)
102 {
103 switch (state) {
> 104 case HCI_DEVCOREDUMP_IDLE:
105 coredump_info.state = BTMTK_COREDUMP_INIT;
106 break;
> 107 case HCI_DEVCOREDUMP_ACTIVE:
108 coredump_info.state = BTMTK_COREDUMP_ACTIVE;
109 break;
> 110 case HCI_DEVCOREDUMP_TIMEOUT:
> 111 case HCI_DEVCOREDUMP_ABORT:
> 112 case HCI_DEVCOREDUMP_DONE:
113 coredump_info.state = BTMTK_COREDUMP_INIT;
114 btmtk_reset_sync(coredump_info.hdev);
115 break;
116 }
117 }
118
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests