RE: [PATCH v3 0/2] wifi: rtw88: error codes fix patches

[Ping-Ke Shih]

> -----Original Message-----
> From: Zhang Shurong <zhang_shurong@xxxxxxxxxxx>
> Sent: Thursday, April 27, 2023 1:02 AM
> To: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: tony0620emma@xxxxxxxxx; kvalo@xxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> Zhang Shurong <zhang_shurong@xxxxxxxxxxx>
> Subject: [PATCH v3 0/2] wifi: rtw88: error codes fix patches
> 
> rtw88 does not handle the failure during copy_from_user or invalid
> user-provided data. We fix such problems by first modifying the return
> value of customized function rtw_debugfs_copy_from_user. Then for all
> the callers rtw_debugfs_set_*, we receive the returned error code.
> Moreover, negative code is returned if the user-provided data is invalid
> instead of a positive value count.
> 
> The changes in this version:
> - check by if (ret) instead of check by if (ret < 0)

It would be better if you preserve the change of v2 as changelog.
v3 is okay to me, so don't need v4 if no other reviewer has comment
for this patchset.

> 
> Zhang Shurong (2):
>   wifi: rtw88: fix incorrect error codes in rtw_debugfs_copy_from_user
>   wifi: rtw88: fix incorrect error codes in rtw_debugfs_set_*
> 
>  drivers/net/wireless/realtek/rtw88/debug.c | 59 ++++++++++++++++------
>  1 file changed, 43 insertions(+), 16 deletions(-)
> 
> --
> 2.40.0
>