Re: [PATCH v3 0/3] blk-integrity: drop integrity_kobj from gendisk

From: Thomas Weißschuh
Date: Wed Apr 26 2023 - 19:12:54 EST


Hi Martin, Christoph, Jens,

On 2023-03-20 07:56:58-0400, Martin K. Petersen wrote:
> > The embedded member integrity_kobj member of struct gendisk violates
> > the assumption of the driver core that only one struct kobject should
> > be embedded into another object and then manages its lifetime.
> >
> > As the integrity_kobj is only used to hold a few sysfs attributes it
> > can be replaced by direct device_attributes and removed.
>
> Looks good to me and passed a quick test on a couple of systems. Thanks
> for cleaning this up!
>
> Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

Am I getting some part of the process for block/ wrong?

It seems my patches for the block subsystem are having a hard time
getting merged.

* https://lore.kernel.org/all/20221110052438.2188-1-linux@xxxxxxxxxxxxxx/
* this series
* https://lore.kernel.org/all/20230419-const-partition-v2-0-817b58f85cd1@xxxxxxxxxxxxxx/

Thanks for any pointers,
Thomas