Re: [PATCH v1 1/1] net/ncsi: Fix the multi thread manner of NCSI driver

[Simon Horman]

On Mon, Apr 24, 2023 at 07:47:42PM +0800, Delphine CC Chiu wrote:
> From: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> 
> Currently NCSI driver will send several NCSI commands back
> to back without waiting the response of previous NCSI command
> or timeout in some state when NIC have multi channel. This
> operation against the single thread manner defined by NCSI
> SPEC(section 6.3.2.3 in DSP0222_1.1.1).
> 
> 1. Fix the problem of NCSI driver that sending command back
> to back without waiting the response of previos NCSI command

Hi Delphine,

a minor nit from my side: s/previos/previous/

> or timeout to meet the single thread manner.
> 2. According to NCSI SPEC(section 6.2.13.1 in DSP0222_1.1.1),
> we should probe one channel at a time by sending NCSI commands
> (Clear initial state, Get version ID, Get capabilities...), than
> repeat this steps until the max number of channels which we got
> from NCSI command (Get capabilities) has been probed.
> 
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>