Re: [PATCH v3 06/21] drm/msm/dpu: Use V2 DITHER PINGPONG sub-block in SM8[34]50/SC8280XP

[Abhinav Kumar]

On 4/26/2023 12:08 PM, Marijn Suijten wrote:
> On 2023-04-26 09:24:19, Abhinav Kumar wrote:
> > On 4/25/2023 4:05 PM, Marijn Suijten wrote:
> > > According to downstream sources this DITHER sub-block sits at an offset
> > > of 0xe0 with version 0x20000.  The PP_BLK_DITHER macro is _not_ used as
> > > downstream still says the size of the PINGPONG block is 0xd4 and not 0.
> >
> > the PINGPONG block size is 0x0 on sm8350, sm8450 and sc8280xp.
> >
> > and length of dither is 0x20 and they all start at 0xe0.
> >
> > So now does anything prevent us from using PP_BLK_DITHER macro for these?
>
> Nothing prevents it from being used (if you are referring to our
> previous conversations) besides this information not being available in
> public DTS (I simply did not know) and the fact that all these many
> fixes - however necessary they are - distract from the main topic of
> this series: bringing INTF TE support to DPU1.

Yeah, you could have sent these as a separate series if you wanted to 
stick to this one being only intf te.

> I'll fit in that patch though, as I have to send v4 anyway.

Thanks.

> - Marijn