Re: [PATCH v2 1/4] can: m_can: Add hrtimer to generate software interrupt

From: Marc Kleine-Budde
Date: Wed Apr 26 2023 - 13:48:16 EST


On 26.04.2023 11:11:12, Mendez, Judith wrote:
[...]
> > print a proper error message using dev_err_probe("IRQ %s not found and
> > polling not activated\n")
> >
> Why %s when MCAN requests 1 IRQ which is "int0"? If we want to print "int0",
> should it be hardcoded into the print error message?

I think I copied the error message from platform_get_irq_byname() and
extended it. Of course it makes sense to hardcode the IRQ name.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature