Aw: Re: [net v2] net: ethernet: mtk_eth_soc: drop generic vlan rx offload, only use DSA untagging

[Frank Wunderlich]

> Gesendet: Mittwoch, 26. April 2023 um 19:25 Uhr
> Von: "Arınç ÜNAL" <arinc.unal@xxxxxxxxxx>
> On 26/04/2023 20:21, Frank Wunderlich wrote:
> > From: Felix Fietkau <nbd@xxxxxxxx>
> > 
> > Through testing I found out that hardware vlan rx offload support seems to
> > have some hardware issues. At least when using multiple MACs and when
> > receiving tagged packets on the secondary MAC, the hardware can sometimes
> > start to emit wrong tags on the first MAC as well.
> > 
> > In order to avoid such issues, drop the feature configuration and use
> > the offload feature only for DSA hardware untagging on MT7621/MT7622
> > devices where this feature works properly.
> > 
> > Fixes: 08666cbb7dd5 ("net: ethernet: mtk_eth_soc: add support for configuring vlan rx offload")
> > Tested-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>
> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > Tested-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> 
> I'm confused by this. What is HW-vlan-untagging, and which SoCs do you 
> think this patch would break this feature? How can I utilise this 
> feature on Linux so I can confirm whether it works or not?

the feature itself breaks vlan on mac of bpi-r3

1 mac is connected to switch and uses dsa tags, the other mac is directly accessible and vlan-tag
there is stripped by this feature.

with this patch i can use vlans on the "standalone" mac again (see tagged packets incoming).

regards Frank