Re: mainline build failure due to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")

From: Laurent Pinchart
Date: Wed Apr 26 2023 - 13:24:16 EST


Hi Sudip,

On Wed, Apr 26, 2023 at 06:07:34PM +0100, Sudip Mukherjee (Codethink) wrote:
> Hi All,
>
> The latest mainline kernel branch fails to build xtensa, mips, arm allmodconfig
> with the error:
>
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_inbuf':
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:33:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
> 33 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c: In function 'mxc_isi_channel_set_outbuf':
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:51:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
> 51 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/media/platform/nxp/imx8-isi/imx8-isi-hw.c:66:5: error: "CONFIG_ARCH_DMA_ADDR_T_64BIT" is not defined, evaluates to 0 [-Werror=undef]
> 66 | #if CONFIG_ARCH_DMA_ADDR_T_64BIT
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> git bisect pointed to cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")
>
> I will be happy to test any patch or provide any extra log if needed.

This issue has been fixed already, the fixes are available in the master
branch of git://linuxtv.org/media_stage.git:

e49b1e1958b4 media: nxp: ignore unused suspend operations
9829ed20b019 media: nxp: imx8-isi: fix buiding on 32-bit

Mauro, can you please include those two fixes in your next pull request
for v6.4 ?

--
Regards,

Laurent Pinchart