Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()`

From: Dongliang Mu
Date: Wed Apr 26 2023 - 11:08:22 EST



On 2023/4/26 22:13, Mark Brown wrote:
On Wed, Apr 26, 2023 at 09:50:26AM +0800, Dongliang Mu wrote:

Second, from code review of platform_get_irq / platform_get_irq_optional, it
would warn IRQ 0 as an invalid IRQ number.
out:
if (WARN(!ret, "0 is an invalid IRQ number\n"))
return -EINVAL;
return ret;
Like I say I'm not sure that's actually accurate for all architectures
yet.

I see. Let's wait and see. When it becomes stable and universal for all architectures, we could clean up them all together.

Currently our team just works to make Smatch happy :)