Re: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

From: kernel test robot
Date: Wed Apr 26 2023 - 09:37:45 EST

Next message: Yosry Ahmed: "[PATCH 0/2] memcg: OOM log improvements"
Previous message: Geert Uytterhoeven: "[PATCH v2] regmap: REGMAP_KUNIT must not select REGMAP"
In reply to: kernel test robot: "Re: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Arseniy,

kernel test robot noticed the following build errors:

[auto build test ERROR on mtd/nand/next]
[also build test ERROR on linus/master v6.3 next-20230425]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Arseniy-Krasnov/mtd-rawnand-macronix-OTP-access-for-MX30LFxG18AC/20230426-153143
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
patch link: https://lore.kernel.org/r/20230426072455.3887717-1-AVKrasnov%40sberdevices.ru
patch subject: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC
config: hexagon-randconfig-r041-20230425 (https://download.01.org/0day-ci/archive/20230426/202304262101.pP2ae1ol-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 437b7602e4a998220871de78afcb020b9c14a661)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3529f3465e99379489b59c035a8a0506c3756ef4
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Arseniy-Krasnov/mtd-rawnand-macronix-OTP-access-for-MX30LFxG18AC/20230426-153143
git checkout 3529f3465e99379489b59c035a8a0506c3756ef4
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/nand/raw/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304262101.pP2ae1ol-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

>> drivers/mtd/nand/raw/nand_macronix.c:384:12: error: call to undeclared function 'kmalloc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
dma_buf = kmalloc(MACRONIX_30LFXG18AC_OTP_PAGE_SIZE, GFP_KERNEL);
^
drivers/mtd/nand/raw/nand_macronix.c:384:12: note: did you mean 'mm_alloc'?
include/linux/sched/mm.h:16:26: note: 'mm_alloc' declared here
extern struct mm_struct *mm_alloc(void);
^
>> drivers/mtd/nand/raw/nand_macronix.c:384:10: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
dma_buf = kmalloc(MACRONIX_30LFXG18AC_OTP_PAGE_SIZE, GFP_KERNEL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mtd/nand/raw/nand_macronix.c:397:17: warning: comparison of distinct pointer types ('typeof ((page)) *' (aka 'unsigned long *') and 'uint64_t *' (aka 'unsigned long long *')) [-Wcompare-distinct-pointer-types]
offs_in_page = do_div(page, MACRONIX_30LFXG18AC_OTP_PAGE_SIZE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/div64.h:222:28: note: expanded from macro 'do_div'
(void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~
>> drivers/mtd/nand/raw/nand_macronix.c:397:17: error: incompatible pointer types passing 'unsigned long *' to parameter of type 'uint64_t *' (aka 'unsigned long long *') [-Werror,-Wincompatible-pointer-types]
offs_in_page = do_div(page, MACRONIX_30LFXG18AC_OTP_PAGE_SIZE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/div64.h:238:22: note: expanded from macro 'do_div'
__rem = __div64_32(&(n), __base); \
^~~~
include/asm-generic/div64.h:213:38: note: passing argument to parameter 'dividend' here
extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
^
>> drivers/mtd/nand/raw/nand_macronix.c:437:2: error: call to undeclared function 'kfree'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
kfree(dma_buf);
^
drivers/mtd/nand/raw/nand_macronix.c:437:2: note: did you mean 'kvfree'?
include/linux/rcutiny.h:99:13: note: 'kvfree' declared here
extern void kvfree(const void *addr);
^
>> drivers/mtd/nand/raw/nand_macronix.c:397:17: warning: shift count >= width of type [-Wshift-count-overflow]
offs_in_page = do_div(page, MACRONIX_30LFXG18AC_OTP_PAGE_SIZE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/div64.h:234:25: note: expanded from macro 'do_div'
} else if (likely(((n) >> 32) == 0)) { \
^ ~~
include/linux/compiler.h:77:40: note: expanded from macro 'likely'
# define likely(x) __builtin_expect(!!(x), 1)
^
2 warnings and 4 errors generated.

vim +/kmalloc +384 drivers/mtd/nand/raw/nand_macronix.c

366
367 static int __macronix_30lfxg18ac_rw_otp(struct mtd_info *mtd,
368 loff_t offs_in_flash,
369 size_t len, size_t *retlen,
370 u_char *buf, bool write)
371 {
372 struct nand_chip *nand;
373 size_t bytes_handled;
374 unsigned long page;
375 off_t offs_in_page;
376 void *dma_buf;
377 int ret;
378
379 /* 'nand_prog/read_page_op()' may use 'buf' as DMA buffer,
380 * so allocate properly aligned memory for it. This is
381 * needed because cross page accesses may lead to unaligned
382 * buffer address for DMA.
383 */
> 384 dma_buf = kmalloc(MACRONIX_30LFXG18AC_OTP_PAGE_SIZE, GFP_KERNEL);
385 if (!dma_buf)
386 return -ENOMEM;
387
388 nand = mtd_to_nand(mtd);
389 nand_select_target(nand, 0);
390
391 ret = macronix_30lfxg18ac_otp_enable(nand);
392 if (ret)
393 goto out_otp;
394
395 page = offs_in_flash;
396 /* 'page' will be result of division. */
> 397 offs_in_page = do_div(page, MACRONIX_30LFXG18AC_OTP_PAGE_SIZE);
398 bytes_handled = 0;
399
400 while (bytes_handled < len &&
401 page < MACRONIX_30LFXG18AC_OTP_PAGES) {
402 size_t bytes_to_handle;
403
404 bytes_to_handle = min_t(size_t, len - bytes_handled,
405 MACRONIX_30LFXG18AC_OTP_PAGE_SIZE -
406 offs_in_page);
407
408 if (write) {
409 memcpy(dma_buf, &buf[bytes_handled], bytes_to_handle);
410 ret = nand_prog_page_op(nand, page, offs_in_page,
411 dma_buf, bytes_to_handle);
412 } else {
413 ret = nand_read_page_op(nand, page, offs_in_page,
414 dma_buf, bytes_to_handle);
415 if (!ret)
416 memcpy(&buf[bytes_handled], dma_buf,
417 bytes_to_handle);
418 }
419 if (ret)
420 goto out_otp;
421
422 bytes_handled += bytes_to_handle;
423 offs_in_page = 0;
424 page++;
425 }
426
427 *retlen = bytes_handled;
428
429 out_otp:
430 if (ret)
431 dev_err(&mtd->dev, "failed to perform OTP IO: %i\n", ret);
432
433 ret = macronix_30lfxg18ac_otp_disable(nand);
434 WARN(ret, "failed to leave OTP mode after %s\n",
435 write ? "write" : "read");
436 nand_deselect_target(nand);
> 437 kfree(dma_buf);
438
439 return ret;
440 }
441

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Next message: Yosry Ahmed: "[PATCH 0/2] memcg: OOM log improvements"
Previous message: Geert Uytterhoeven: "[PATCH v2] regmap: REGMAP_KUNIT must not select REGMAP"
In reply to: kernel test robot: "Re: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]