Re: [PATCH] hwmon: (max597x) Add Maxim Max597x

From: kernel test robot
Date: Wed Apr 26 2023 - 08:35:39 EST


Hi Naresh,

kernel test robot noticed the following build warnings:

[auto build test WARNING on b4c288cfd2f84c44994330c408e14645d45dee5b]

url: https://github.com/intel-lab-lkp/linux/commits/Naresh-Solanki/hwmon-max597x-Add-Maxim-Max597x/20230426-170556
base: b4c288cfd2f84c44994330c408e14645d45dee5b
patch link: https://lore.kernel.org/r/20230426090356.745979-1-Naresh.Solanki%409elements.com
patch subject: [PATCH] hwmon: (max597x) Add Maxim Max597x
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230426/202304262021.nGJgsK76-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/3d6f729d86a79adf0603717c79bc389a5dcc4444
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Naresh-Solanki/hwmon-max597x-Add-Maxim-Max597x/20230426-170556
git checkout 3d6f729d86a79adf0603717c79bc389a5dcc4444
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202304262021.nGJgsK76-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/hwmon/max597x.c: In function 'max597x_read':
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_chip' not handled in switch [-Wswitch]
47 | switch (type) {
| ^~~~~~
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_temp' not handled in switch [-Wswitch]
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_power' not handled in switch [-Wswitch]
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_energy' not handled in switch [-Wswitch]
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_humidity' not handled in switch [-Wswitch]
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_fan' not handled in switch [-Wswitch]
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_pwm' not handled in switch [-Wswitch]
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_intrusion' not handled in switch [-Wswitch]
>> drivers/hwmon/max597x.c:47:9: warning: enumeration value 'hwmon_max' not handled in switch [-Wswitch]


vim +/hwmon_chip +47 drivers/hwmon/max597x.c

40
41 static int max597x_read(struct device *dev, enum hwmon_sensor_types type,
42 u32 attr, int channel, long *val)
43 {
44 struct max597x_hwmon *ddata = dev_get_drvdata(dev);
45 int ret;
46
> 47 switch (type) {
48 case hwmon_curr:
49 switch (attr) {
50 case hwmon_curr_input:
51 ret = max597x_read_reg(ddata, MAX5970_REG_CURRENT_H(channel),
52 ddata->irng[channel], val);
53 if (ret < 0)
54 return ret;
55
56 return 0;
57 default:
58 return -EOPNOTSUPP;
59 }
60
61 case hwmon_in:
62 switch (attr) {
63 case hwmon_in_input:
64 ret = max597x_read_reg(ddata, MAX5970_REG_VOLTAGE_H(channel),
65 ddata->mon_rng[channel], val);
66 if (ret < 0)
67 return ret;
68 return 0;
69 default:
70 return -EOPNOTSUPP;
71 }
72 }
73 return -EOPNOTSUPP;
74 }
75

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests