[tip: timers/core] clocksource/drivers/exynos_mct: Explicitly return 0 for shared timer

From: tip-bot2 for Krzysztof Kozlowski
Date: Wed Apr 26 2023 - 05:14:42 EST


The following commit has been merged into the timers/core branch of tip:

Commit-ID: fd3f088f35f610a7ee3045b7d172b362342e43c6
Gitweb: https://git.kernel.org/tip/fd3f088f35f610a7ee3045b7d172b362342e43c6
Author: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
AuthorDate: Mon, 03 Apr 2023 11:40:17 +02:00
Committer: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
CommitterDate: Mon, 24 Apr 2023 16:56:13 +02:00

clocksource/drivers/exynos_mct: Explicitly return 0 for shared timer

For a shared timers, the mct_init_dt() should not initialize the clock
even with global comparator. This is not an error, thus the function
should simply return 0, not 'ret'.

This also fixes smatch warning:

drivers/clocksource/exynos_mct.c:635 mct_init_dt() warn: missing error code? 'ret'

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <error27@xxxxxxxxx>
Link: https://lore.kernel.org/r/202304021446.46XVKag0-lkp@xxxxxxxxx/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Reviewed-by: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20230403094017.9556-1-krzysztof.kozlowski@xxxxxxxxxx
---
drivers/clocksource/exynos_mct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index bfd6009..ef8cb1b 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -682,7 +682,7 @@ static int __init mct_init_dt(struct device_node *np, unsigned int int_type)
* processor cannot use the global comparator.
*/
if (frc_shared)
- return ret;
+ return 0;

return exynos4_clockevent_init();
}