Re: [PATCH] rust: Sort rust/helpers.c's #include directives

From: Ariel Miculas
Date: Wed Apr 26 2023 - 04:24:40 EST


My bad, I'm sending this again from my cisco account.

On Wed, Apr 26, 2023 at 11:14 AM Ariel Miculas <ariel.miculas@xxxxxxxxx> wrote:
>
> Sort the #include directives of rust/helpers.c alphabetically and add a
> comment specifying this.
>
> Suggested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> Link: https://github.com/Rust-for-Linux/linux/issues/1003
> Signed-off-by: Ariel Miculas <amiculas@xxxxxxxxx>
> ---
> rust/helpers.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 81e80261d597..73c01db0c828 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -16,15 +16,17 @@
> *
> * All symbols are exported as GPL-only to guarantee no GPL-only feature is
> * accidentally exposed.
> + *
> + * Sorted alphabetically.
> */
>
> #include <linux/bug.h>
> #include <linux/build_bug.h>
> #include <linux/err.h>
> -#include <linux/refcount.h>
> #include <linux/mutex.h>
> -#include <linux/spinlock.h>
> +#include <linux/refcount.h>
> #include <linux/sched/signal.h>
> +#include <linux/spinlock.h>
> #include <linux/wait.h>
>
> __noreturn void rust_helper_BUG(void)
> --
> 2.40.0
>