Re: [PATCH v13 6/6] clk: meson: a1: add Amlogic A1 Peripherals clock controller driver

[Dmitry Rokosov]

On Sun, Apr 23, 2023 at 11:30:38PM +0200, Martin Blumenstingl wrote:
> On Wed, Apr 5, 2023 at 9:59 PM Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> wrote:
> [...]
> > +static const struct of_device_id a1_periphs_clkc_match_table[] = {
> > +       { .compatible = "amlogic,a1-clkc", },
> > +       {},
> nit-pick: please remove the comma after the sentinel
> 

Thank you for bringing up that point! There's no problem with removing
it in the next version of the product. I'll prepare it.

> > +MODULE_DEVICE_TABLE(of, a1_periphs_clkc_match_table);
> > +
> > +static struct platform_driver a1_periphs_clkc_driver = {
> > +       .probe = meson_a1_periphs_probe,
> > +       .driver = {
> > +               .name = "a1-clkc",
> > +               .of_match_table = of_match_ptr(a1_periphs_clkc_match_table),
> I wonder if we should drop of_match_ptr() here as no other meson clock
> driver uses it.
> Also there's commits like 00cb754ac622 ("clk: imx8mq: drop
> of_match_ptr from of_device_id table") which explicitly remove it from
> other drivers.

Exactly, all Meson clock drivers depend on the ARM64 config, which in
turn selects CONFIG_OF by default. So of_match_ptr can be dropped.

> 
> Apart form these two this patch looks great to me.
> 

-- 
Thank you,
Dmitry