Re: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq

From: Dongliang Mu
Date: Tue Apr 25 2023 - 05:10:52 EST



On 2023/4/25 16:57, Sergey Shtylyov wrote:
Hello!

On 4/24/23 1:59 PM, lihuya wrote:

platform_get_irq() only return non-zero irq number on success, or
negative error number on failure.

There is no need to check the return value of platform_get_irq()
to determine the return value of dwc3_otg_get_irq(), removing
them to solve this problem.
I was going to submit such patch myself at some point... which
has never happened. :-/

Signed-off-by: lihuya <lihuya@xxxxxxxxxxx>
Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

Hi Sergey,

Please take a look at the following thread [1]. Yuhang sent a v2 patch since he did not use his real name in the Signed-off-by.

Greg already had some comments on this patch.

[1] https://lore.kernel.org/lkml/20230425015532.13622-1-lihuya@xxxxxxxxxxx/


[...]

MBR, Sergey