Re: [PATCH -next] drm/stm: dsi: Use devm_platform_ioremap_resource()

From: Raphael Gallais-Pou
Date: Tue Apr 25 2023 - 04:27:31 EST


Hi Yang,

On 4/21/23 10:34, Yang Li wrote:
> Convert platform_get_resource(),devm_ioremap_resource() to a single call
> to devm_platform_ioremap_resource(), as this is exactly what this function
> does.
>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 89897d5f5c72..1750b6a25e87 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -444,15 +444,13 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> struct dw_mipi_dsi_stm *dsi;
> struct clk *pclk;
> - struct resource *res;
> int ret;
>
> dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
> if (!dsi)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dsi->base = devm_ioremap_resource(dev, res);
> + dsi->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dsi->base)) {
> ret = PTR_ERR(dsi->base);
> DRM_ERROR("Unable to get dsi registers %d\n", ret);


Thanks for the patch.

Acked-by: Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>