Re: [PATCH 0/4] cxl: Add a firmware update mechanism and cxl_test emulation

[Davidlohr Bueso]

On Fri, 21 Apr 2023, Vishal Verma wrote:

> The poll interval for the Transfer FW command is arbitrarily set at 1
> second, and a poll count of 300, giving us a total wait time of five
> minutes before which each slice of the transfer times out. This seems
> like a good mix of responsiveness and a total wait - the spec doesn't
> have any guidance on any upper or lower bounds for this. This likely
> does not need to be user-configurable, so for now it is just hard-coded
> in the driver.

Nothing against this, just thinking that in general, but we should
probably limit the poll interval to CXL_MAILBOX_TIMEOUT_MS. I'm not
sure, however, what would be a proper value across all commands. Or
would having this limit be per-cmd make more sense instead?

Thanks,
Davidlohr