Re: [PATCH v2 06/24] selftests/resctrl: Express span in bytes

From: Ilpo Järvinen
Date: Mon Apr 24 2023 - 11:31:53 EST


On Fri, 21 Apr 2023, Reinette Chatre wrote:
> On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> > Make MBA and MBM tests to use megabytes to represent span. CMT test
> > uses bytes.
> >
> > Convert MBA and MBM tests to use bytes like CMT test to remove the
> > inconsistency between the tests. This also allows removing test
> > dependent buffer sizing from run_benchmark().
>
> It is not clear to me how this patch achieves this goal since after
> it show_mba_info() still displays results in MB.

This was more for internal consistency as there was the test type
dependent span calculation in run_benchmark(). I can fix the changelog to
reflect that, however, what you think would be the best approach in
show_bw_info(), should I leave the print to use MB (converting the
internal representation back from bytes to MB there)?

--
i.