Re: [PATCH v3 2/4] arm64: dts: qcom: sa8155p-adp: Make -cells decimal

From: Andrew Halaney
Date: Mon Apr 24 2023 - 10:39:55 EST


On Mon, Apr 24, 2023 at 09:21:45AM +0200, Krzysztof Kozlowski wrote:
> On 21/04/2023 22:55, Andrew Halaney wrote:
> > The property logically makes sense in decimal, and is the standard used
> > elsewhere.
> >
> > Suggested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > Signed-off-by: Andrew Halaney <ahalaney@xxxxxxxxxx>
> > ---
> >
> > Changes since v2:
> > * Collect tags
> > Changes since v1:
> > * New patch (Konrad)
>
> Doing such changes per one board will be a lot of churn...
>

Agreed, are you suggesting I drop this patch (and if we do this sort of
cleanup to do it in bulk)? Sorry, not entirely sure I am picking up what
that comment is implying.

Personally, I'd prefer to keeping that patch as this series is trying to
clean up the particular ethernet node.. but if the purpose of the series
was just to clean -cells up then I'd go with the bulk approach.

So as is, I'm going to leave it like so unless you have specific advice
against doing so.

Thanks,
Andrew