[PATCH v3 1/2] mm/page_alloc: drop the unnecessary pfn_valid() for start pfn

From: Baolin Wang
Date: Mon Apr 24 2023 - 09:46:12 EST


__pageblock_pfn_to_page() currently performs both pfn_valid check and
pfn_to_online_page(). The former one is redundant because the latter is a
stronger check. Drop pfn_valid().

Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
Reviewed-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
Acked-by: Michal Hocko <mhocko@xxxxxxxx>
---
Changes from v2:
- Update the commit message per Michal. Thanks.
- Add acked tag from Michal.
Changes from v1:
- Collect reviewed tags. Thanks David and Ying.
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9de2a18519a1..6457b64fe562 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1512,7 +1512,7 @@ struct page *__pageblock_pfn_to_page(unsigned long start_pfn,
/* end_pfn is one past the range we are checking */
end_pfn--;

- if (!pfn_valid(start_pfn) || !pfn_valid(end_pfn))
+ if (!pfn_valid(end_pfn))
return NULL;

start_page = pfn_to_online_page(start_pfn);
--
2.27.0