Re: [PATCH] spi: remove return value check of debugfs_create_dir()

From: Mark Brown
Date: Mon Apr 24 2023 - 07:54:59 EST


On Sun, Apr 23, 2023 at 02:11:54PM +0800, Yingsha Xu wrote:
> Smatch complains that:
> dw_spi_debugfs_init() warn: 'dws->debugfs' is an error pointer
> or valid
>
> Debugfs checks are generally not supposed to be checked for errors
> and it is not necessary here.
>
> Just delete the dead code.

This is very much a question of taste with a range of use cases
available.

Attachment: signature.asc
Description: PGP signature