Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()`

From: Mark Brown
Date: Mon Apr 24 2023 - 07:48:57 EST


On Sun, Apr 23, 2023 at 03:24:46AM +0000, Li Ningke wrote:
> Smatch complains that
> drivers/spi/spi-davinci.c:915 davinci_spi_probe() warn:
> platform_get_irq() does not return zero
>
> There is no need to check whether the return value is zero as
> `platform_get_irq()` only returns non-zero IRQ number on success
> or negative error number on failure, removing them to solve this
> problem.

Is that check valid? 0 was a valid interrupt for some architectures...

Attachment: signature.asc
Description: PGP signature