Re: [PATCH] MIPS: uprobes: Restore thread.trap_nr

From: Thomas Bogendoerfer
Date: Mon Apr 24 2023 - 07:33:33 EST


On Sun, Apr 23, 2023 at 09:38:03AM +0800, Tiezhu Yang wrote:
> thread.trap_nr is saved in arch_uprobe_pre_xol(), it should be restored
> in arch_uprobe_{post,abort}_xol() accordingly, actually it was only done
> in the post function, just do it in the abort function too, this change
> is similar with x86 and powerpc.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> ---
> arch/mips/kernel/uprobes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/kernel/uprobes.c b/arch/mips/kernel/uprobes.c
> index 6b630ed..401b148 100644
> --- a/arch/mips/kernel/uprobes.c
> +++ b/arch/mips/kernel/uprobes.c
> @@ -191,6 +191,7 @@ void arch_uprobe_abort_xol(struct arch_uprobe *aup,
> {
> struct uprobe_task *utask = current->utask;
>
> + current->thread.trap_nr = utask->autask.saved_trap_nr;
> instruction_pointer_set(regs, utask->vaddr);
> }
>
> --
> 2.1.0

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]